Page MenuHomePhabricator

Recent Activity

Today

spatel accepted D138542: [InstSimplify] Use dominate condtion to simplify instructions.

LGTM

Sat, Nov 26, 4:36 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D119138: [clang-format] Further improve support for requires expressions.

Generally, why do we need to have that much information? I.e. why do we need to know the exact type of the "requires" keyword?
I do understand we need to know the brace type, but that seems like it would be easier to figure out in the TokenAnnotator (where we already parsed UnwrappedLines).
Do we ever parse UnwrappedLines differently depending on requires clauses/expressions?
If not, we should really do the annotation in TokenAnnotator, where we already have nice parsing bounds from the parsed UnwrappedLines.

Sat, Nov 26, 4:26 AM · Restricted Project, Restricted Project, Restricted Project
klimek added a comment to D119138: [clang-format] Further improve support for requires expressions.

Generally, why do we need to have that much information? I.e. why do we need to know the exact type of the "requires" keyword?
I do understand we need to know the brace type, but that seems like it would be easier to figure out in the TokenAnnotator (where we already parsed UnwrappedLines).
Do we ever parse UnwrappedLines differently depending on requires clauses/expressions?
If not, we should really do the annotation in TokenAnnotator, where we already have nice parsing bounds from the parsed UnwrappedLines.

Sat, Nov 26, 2:58 AM · Restricted Project, Restricted Project, Restricted Project
realqhc requested review of D138743: [flang] Diagnostic for shape argument in c_f_pointer.
Sat, Nov 26, 2:47 AM · Restricted Project, Restricted Project
xen0n updated the diff for D138135: [WIP][ELF] Support LoongArch.

rebase

Sat, Nov 26, 12:50 AM · Restricted Project, Restricted Project
xen0n updated the diff for D138016: [Object] Add some more LoongArch support.

rebase and add to unit test case

Sat, Nov 26, 12:49 AM · Restricted Project, Restricted Project
xen0n added inline comments to D138135: [WIP][ELF] Support LoongArch.
Sat, Nov 26, 12:41 AM · Restricted Project, Restricted Project
xen0n updated the diff for D138135: [WIP][ELF] Support LoongArch.

Check for overflows for R_LARCH_32_PCREL according to @MQ-mengqing's
comments, and small comment tweaks.

Sat, Nov 26, 12:40 AM · Restricted Project, Restricted Project
LuoYuanke added inline comments to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Sat, Nov 26, 12:34 AM · Restricted Project, Restricted Project
xen0n updated the summary of D138135: [WIP][ELF] Support LoongArch.
Sat, Nov 26, 12:30 AM · Restricted Project, Restricted Project
xen0n added inline comments to D138135: [WIP][ELF] Support LoongArch.
Sat, Nov 26, 12:29 AM · Restricted Project, Restricted Project
xen0n updated the diff for D138135: [WIP][ELF] Support LoongArch.

Confirmed no other LoongArch relocs than R_LARCH_B{16,21,26} have
overflow or alignment checking, and updated some comments.

Sat, Nov 26, 12:23 AM · Restricted Project, Restricted Project
kazu committed rGbba55813fc4e: [Scalar] Use std::optional in LoopFlatten.cpp (NFC) (authored by kazu).
[Scalar] Use std::optional in LoopFlatten.cpp (NFC)
Sat, Nov 26, 12:03 AM · Restricted Project, Restricted Project
kazu committed rG7fc772bbdc34: [Scalar] Use std::optional in InductiveRangeCheckElimination.cpp (NFC) (authored by kazu).
[Scalar] Use std::optional in InductiveRangeCheckElimination.cpp (NFC)
Sat, Nov 26, 12:00 AM · Restricted Project, Restricted Project

Yesterday

kazu committed rGb54cd3f09c96: [Scalar] Use std::optional in GVN.cpp (NFC) (authored by kazu).
[Scalar] Use std::optional in GVN.cpp (NFC)
Fri, Nov 25, 11:56 PM · Restricted Project, Restricted Project
kazu committed rGedace862f63a: [Scalar] Use std::optional in CorrelatedValuePropagation.cpp (NFC) (authored by kazu).
[Scalar] Use std::optional in CorrelatedValuePropagation.cpp (NFC)
Fri, Nov 25, 11:53 PM · Restricted Project, Restricted Project
kazu committed rG3da96e0361f5: [InstCombine] Use std::optional in InstructionCombining.cpp (NFC) (authored by kazu).
[InstCombine] Use std::optional in InstructionCombining.cpp (NFC)
Fri, Nov 25, 11:50 PM · Restricted Project, Restricted Project
kazu committed rG881076cde296: [InstCombine] Use std::optional in InstCombinePHI.cpp (NFC) (authored by kazu).
[InstCombine] Use std::optional in InstCombinePHI.cpp (NFC)
Fri, Nov 25, 11:47 PM · Restricted Project, Restricted Project
kazu committed rGc7fa15c0f21b: [IPO] Use std::optional in IROutliner.cpp (NFC) (authored by kazu).
[IPO] Use std::optional in IROutliner.cpp (NFC)
Fri, Nov 25, 11:44 PM · Restricted Project, Restricted Project
kazu committed rGa5f8a36d0298: [IPO] Use std::optional in GlobalOpt.cpp (NFC) (authored by kazu).
[IPO] Use std::optional in GlobalOpt.cpp (NFC)
Fri, Nov 25, 11:38 PM · Restricted Project, Restricted Project
yronglin added a comment to D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg.

pin~

Fri, Nov 25, 11:38 PM · Restricted Project, Restricted Project
kazu committed rGffba7ee77831: [IPO] Use std::optional in Attributor.cpp (NFC) (authored by kazu).
[IPO] Use std::optional in Attributor.cpp (NFC)
Fri, Nov 25, 11:35 PM · Restricted Project, Restricted Project
kazu committed rG629819cb6613: [IPO] Use std::optional in AttributorAttributes.cpp (NFC) (authored by kazu).
[IPO] Use std::optional in AttributorAttributes.cpp (NFC)
Fri, Nov 25, 11:24 PM · Restricted Project, Restricted Project
kazu committed rG8dd2416e44de: [Coroutines] Use std::optional in CoroFrame.cpp (NFC) (authored by kazu).
[Coroutines] Use std::optional in CoroFrame.cpp (NFC)
Fri, Nov 25, 11:18 PM · Restricted Project, Restricted Project
kazu committed rGd7fdb5d87b3c: [Coroutines] Use std::optional in CoroElide.cpp (NFC) (authored by kazu).
[Coroutines] Use std::optional in CoroElide.cpp (NFC)
Fri, Nov 25, 11:16 PM · Restricted Project, Restricted Project
kazu committed rG3583f4ff4b1e: [X86] Use std::optional in X86SpeculativeLoadHardening.cpp (NFC) (authored by kazu).
[X86] Use std::optional in X86SpeculativeLoadHardening.cpp (NFC)
Fri, Nov 25, 11:13 PM · Restricted Project, Restricted Project
kazu committed rG14931309015d: [RISCV] Use std::optional in RISCVMergeBaseOffset.cpp (NFC) (authored by kazu).
[RISCV] Use std::optional in RISCVMergeBaseOffset.cpp (NFC)
Fri, Nov 25, 11:08 PM · Restricted Project, Restricted Project
kazu committed rG2f61c6c63953: [RISCV] Use std::optional in RISCVISelLowering.cpp (NFC) (authored by kazu).
[RISCV] Use std::optional in RISCVISelLowering.cpp (NFC)
Fri, Nov 25, 11:05 PM · Restricted Project, Restricted Project
kazu committed rG362ca6cbefd7: [RISCV] Use std::optional in RISCVISelDAGToDAG.cpp (NFC) (authored by kazu).
[RISCV] Use std::optional in RISCVISelDAGToDAG.cpp (NFC)
Fri, Nov 25, 11:02 PM · Restricted Project, Restricted Project
kazu committed rG7e008206863f: [RISCV] Use std::optional in RISCVGatherScatterLowering.cpp (NFC) (authored by kazu).
[RISCV] Use std::optional in RISCVGatherScatterLowering.cpp (NFC)
Fri, Nov 25, 11:00 PM · Restricted Project, Restricted Project
kazu committed rGc672bb674c66: [PowerPC] Use std::optional in PPCMacroFusion.cpp (NFC) (authored by kazu).
[PowerPC] Use std::optional in PPCMacroFusion.cpp (NFC)
Fri, Nov 25, 10:57 PM · Restricted Project, Restricted Project
kazu committed rGda4dd0aaf3fa: [NVPTX] Use std::optional in NVPTXTargetTransformInfo.cpp (NFC) (authored by kazu).
[NVPTX] Use std::optional in NVPTXTargetTransformInfo.cpp (NFC)
Fri, Nov 25, 10:55 PM · Restricted Project, Restricted Project
kazu committed rG704b4f353357: [AsmParser] Use std::optional in LanaiAsmParser.cpp (NFC) (authored by kazu).
[AsmParser] Use std::optional in LanaiAsmParser.cpp (NFC)
Fri, Nov 25, 10:52 PM · Restricted Project, Restricted Project
dcaballe requested review of D138742: [mlir][Vector] Remove 'lower-permutation-maps' option from VectorToSCF.
Fri, Nov 25, 10:52 PM · Restricted Project, Restricted Project
kazu committed rG9d7faffa108c: [Hexagon] Use std::optional in HexagonFrameLowering.cpp (NFC) (authored by kazu).
[Hexagon] Use std::optional in HexagonFrameLowering.cpp (NFC)
Fri, Nov 25, 10:49 PM · Restricted Project, Restricted Project
Michael137 updated the diff for D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted.
  • Update comment
Fri, Nov 25, 10:48 PM · Restricted Project, Restricted Project
kazu committed rGac7af9a0b871: [ARM] Use std::optional in ARMISelDAGToDAG.cpp (NFC) (authored by kazu).
[ARM] Use std::optional in ARMISelDAGToDAG.cpp (NFC)
Fri, Nov 25, 10:45 PM · Restricted Project, Restricted Project
kazu committed rGaad2d272bf9e: [Utils] Use std::optional in AMDGPUBaseInfo.cpp (NFC) (authored by kazu).
[Utils] Use std::optional in AMDGPUBaseInfo.cpp (NFC)
Fri, Nov 25, 10:43 PM · Restricted Project, Restricted Project
kazu committed rG09e0aeaaaaff: [AMDGPU] Use std::optional in SIPeepholeSDWA.cpp (NFC) (authored by kazu).
[AMDGPU] Use std::optional in SIPeepholeSDWA.cpp (NFC)
Fri, Nov 25, 10:40 PM · Restricted Project, Restricted Project
kazu committed rG96cb34ab5a43: [AsmParser] Use std::optional in AMDGPUAsmParser.cpp (NFC) (authored by kazu).
[AsmParser] Use std::optional in AMDGPUAsmParser.cpp (NFC)
Fri, Nov 25, 10:37 PM · Restricted Project, Restricted Project