Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible clarifications and consistency fixes for row pitch and slice pitch #629

Open
bashbaug opened this issue Jun 21, 2021 · 0 comments
Open
Labels
OpenCL API Spec

Comments

@bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Jun 21, 2021

The fix for issue #624 added an error condition for the slice pitch for clEnqueueReadImage and clEnqueueWriteImage but a few related parts of the spec could still use attention:

  • Should there be a requirement that the row_pitch or input_row_pitch must be zero?
  • The currently descriptions are slightly contradictory and say that e.g. the value "must be greater than or equal to the element size in bytes × width" but then that if "row_pitch is set to 0, the appropriate row pitch is calculated". It would be better to say that the value must be zero or greater than the proper value in these cases.

I initially thought similar clarifications could be needed for the row pitch and slice pitch arguments to clEnqueueReadBufferRect, clEnqueueWriteBufferRect, and clEnqueueCopyBufferRect would be needed, but after looking more closely I think they're OK.

@bashbaug bashbaug added the OpenCL API Spec label Jun 21, 2021
@bashbaug bashbaug added this to To do in OpenCL specification maintenance via automation Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenCL API Spec
Development

No branches or pull requests

1 participant