Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-fallthrough warning in build #624

Open
charles-lunarg opened this issue Jul 20, 2021 · 0 comments
Open

Enable no-fallthrough warning in build #624

charles-lunarg opened this issue Jul 20, 2021 · 0 comments
Labels
build
Milestone

Comments

@charles-lunarg
Copy link
Collaborator

@charles-lunarg charles-lunarg commented Jul 20, 2021

PR #623 was made due to this warning being enabled by default, it is good practice to enable as many warnings as is possible. There are a couple of places where fall throughs occur in the code already, so either making them not fall through or using special syntax to indicate it is intended would be preferable. The existing //fallthrough comments may be sufficient for this purpose.

@KarenGhavam-lunarG KarenGhavam-lunarG added the build label Jul 28, 2021
@KarenGhavam-lunarG KarenGhavam-lunarG added this to the P3 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build
Projects
None yet
Development

No branches or pull requests

2 participants