Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise loader compiler warnings and errors #680

Closed
charles-lunarg opened this issue Sep 10, 2021 · 1 comment
Closed

Revise loader compiler warnings and errors #680

charles-lunarg opened this issue Sep 10, 2021 · 1 comment
Assignees
Labels
build enhancement

Comments

@charles-lunarg
Copy link
Collaborator

@charles-lunarg charles-lunarg commented Sep 10, 2021

#677 Revealed that the loader failed to compile in a configuration that isn't in github actions or webhook CI. This is a deficiency in the loader's cmake build scripts that should be rectified.

Cody helpfully explained how to see the build that highlighted the error in #679. Advised to use the commands which invoked the compilers as a reference when revising the build command in the repo.

@charles-lunarg charles-lunarg self-assigned this Sep 10, 2021
@charles-lunarg charles-lunarg added build enhancement labels Feb 15, 2022
@charles-lunarg
Copy link
Collaborator Author

@charles-lunarg charles-lunarg commented Mar 30, 2022

I have enabled /W4 level errors in MSVC, as -Wextra and -Wall were present for gcc/clang builds.

This should help to catch further errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement
Projects
None yet
Development

No branches or pull requests

1 participant