Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and removed fixed length strings in the loader #792

Open
charles-lunarg opened this issue Jan 17, 2022 · 1 comment
Open

Investigate and removed fixed length strings in the loader #792

charles-lunarg opened this issue Jan 17, 2022 · 1 comment
Labels
enhancement
Milestone

Comments

@charles-lunarg
Copy link
Collaborator

@charles-lunarg charles-lunarg commented Jan 17, 2022

The loader shouldn't use fixed length strings in most places as not everywhere has a mandate that the length of a string is arbitrarily limited (unlike layer & extension names which are).

This issue is both an exploratory issue to find possible instances of fixed length strings and to fix them.

@charles-lunarg charles-lunarg added the enhancement label Jan 17, 2022
@charles-lunarg charles-lunarg added this to the P3 milestone Jan 17, 2022
@charles-lunarg
Copy link
Collaborator Author

@charles-lunarg charles-lunarg commented Apr 14, 2022

This would help a small amount in the performance department as the loader spends a non-trivial amount of time mem-setting strings to zero which isn't necessary if strings were only as long as they needed to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

No branches or pull requests

1 participant