Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: Add support for ListRepositoriesV2 and ListManifests commands. #1069

Conversation

CollinShoop
Copy link
Contributor

@CollinShoop CollinShoop commented Dec 7, 2021

CON-3907

Required bump to godo 1.73

@CollinShoop CollinShoop force-pushed the docr/add-list-manifest-and-list-repositories-v2-subcommands branch from 758f2d6 to 8fd63d2 Compare Dec 7, 2021
andrewsomething
andrewsomething previously approved these changes Dec 7, 2021
Copy link
Member

@andrewsomething andrewsomething left a comment

👍 This looks great.

I did have a question inline about helping users understand the difference between list and list-v2

listRepositoriesV2Desc := `This command retrieves information about repositories in a registry, including:
- The repository name
- The latest manifest of the repository
- The latest manifest's latest tag, if any
- The number of tags in the repository
- The number of manifests in the repository
`
Copy link
Member

@andrewsomething andrewsomething Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is some additional info we could provide to users that would help them choose between list and list-v2?

Copy link
Contributor Author

@CollinShoop CollinShoop Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I was thinking just the fact of v2 and seeing the different results would be self explanatory. I'm open to suggestions

Copy link
Member

@andrewsomething andrewsomething Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've gone with hiding v1, it probably not very important now.

commands/registry.go Show resolved Hide resolved
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@andrewsomething andrewsomething self-requested a review Dec 7, 2021
@andrewsomething andrewsomething merged commit 22869cb into digitalocean:main Dec 7, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants