Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repetitive usage of --tag flag for Kubernetes node pools #732

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Jan 29, 2020

The flag was read as a string, which did not allow for multiple values to be aggregated and submitted together. Instead, the last --tag value would be used only.

Changing to AddStringSliceFlag fixes the problem.

The flag was read as a string, which did not allow for multiple values
to be aggregated and submitted together. Instead, the last --tag value
would be used only.

Changing to AddStringSliceFlag fixes the problem.
@Verolop Verolop self-assigned this Jan 29, 2020
Copy link
Contributor

@Verolop Verolop left a comment

LGTM

@Verolop Verolop merged commit 884a996 into digitalocean:master Jan 29, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants