Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/stretchr/testify/mock #749

Merged
merged 2 commits into from Feb 19, 2020

Conversation

bentranter
Copy link
Member

@bentranter bentranter commented Feb 18, 2020

Removes github.com/stretchr/testify/mock and replaces it with github.com/golang/mock (known as gomock), so that,

  • We're consistent with the rest of our codebase,
  • We can remove our dependency github.com/stretchr/objx, since the version that is pointed to by github.com/stretchr/testify/mock has a security vulnerability.

bentranter added 2 commits Feb 18, 2020
Removes the SSH runner's mocks and replaces them with gomock's mocks.
@bentranter bentranter requested review from zachgersh, hilary and Verolop Feb 18, 2020
Copy link
Contributor

@Verolop Verolop left a comment

lgtm

@Verolop Verolop merged commit 316f151 into digitalocean:master Feb 19, 2020
2 checks passed
@bentranter bentranter deleted the remove-testify-mock branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants