Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate logic, droplet create --tagName(s) #754

Merged
merged 1 commit into from Mar 5, 2020

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Mar 3, 2020

Per @andrewsomething

"A bit of context: For Droplet --tag-name first checks that the tag
exists since, when first introduced, that was a prerequisite. If the
user had not already created that tag, the Droplet create request
would fail. These days, we will automatically create the tag for the
user if they attempt to create a Droplet using a tag that did not
previously exist. So that check is now redundant and just adds an
unnecessary API call."

In fact, it adds three unnecessary API calls!

We should look at pulling --tagName from the docs at a later time.

Per @andrewsomething

"A bit of context: For Droplet --tag-name first checks that the tag
exists since, when first introduced, that was a prerequisite. If the
user had not already created that tag, the Droplet create request
would fail. These days, we will automatically create the tag for the
user if they attempt to create a Droplet using a tag that did not
previously exist. So that check is now redundant and just adds an
unnecessary API call."

In fact, it adds three unnecessary API calls!

We should look at pulling --tagName from the docs at a later time.
Copy link
Member

@bentranter bentranter left a comment

Tried this out locally, and reviewed here. Looks great!

@hilary hilary merged commit cd06cef into digitalocean:master Mar 5, 2020
2 checks passed
@hilary hilary deleted the cleanup_tag branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants