Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CmdBuilderWithDocs with new CmdBuilder. #761

Merged
merged 4 commits into from Mar 10, 2020

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Mar 9, 2020

As the comment for CmdBuilderWithDocs states, it was introduced to transition away from the current CmdBuilder implementation incrementally. The original CmdBuilder took one description argument and passed it on to Cobra as both the long description and the short description. Now that all commands are using CmdBuilderWithDocs, we can get rid of one of the two separate implementations. This PR:

  • Adds a second description argument to the few commands (mostly deprecated ones) left that didn't already have them.
  • It gives renames CmdBuilderWithDocs to CmdBuilder and removes old implementation of the latter.
  • Replace all usage of CmdBuilderWithDocs with CmdBuilder.

bentranter
bentranter previously approved these changes Mar 10, 2020
Copy link
Member

@bentranter bentranter left a comment

Looks good to me, I think the only thing will be rebasing against #736, since that still uses CmdBuilderWithDocs in commands/databases.go.

@andrewsomething
Copy link
Member Author

@andrewsomething andrewsomething commented Mar 10, 2020

@bentranter Thanks! Rebased this on master and accounted for #736.

@andrewsomething andrewsomething requested a review from bentranter Mar 10, 2020
Copy link
Member

@bentranter bentranter left a comment

Looks great, thanks a ton @andrewsomething!

@bentranter bentranter merged commit 13044b6 into digitalocean:master Mar 10, 2020
2 checks passed
@andrewsomething andrewsomething deleted the asb/cmdbuilder branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants