Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice to 'compute image list' output about '--public' flag when response empty. #785

Merged
merged 1 commit into from Apr 15, 2020

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Apr 15, 2020

We've been reluctant to change this behavior due to the potential to break scripting for existing users, but it is clear that this can be confusing, especially when no private images exist. This PR adds a notice to compute image list output about the --public flag when the response is empty.

See: #314 & #784

Copy link
Member

@bentranter bentranter left a comment

Looks good to me!

@bentranter bentranter merged commit f9ac16a into digitalocean:master Apr 15, 2020
2 checks passed
@andrewsomething andrewsomething deleted the image-ls-notice branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants