Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Snap package with core20 and snapcraft 4.0.x #822

Merged
merged 5 commits into from Jun 9, 2020

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Jun 9, 2020

snapcraft 4.0.4 has been promoted to the stable channel and is now the default. This PR contains the changes required to build Snap package with core20 and snapcraft 4.0.x

  • Updates the Docker image to use Ubuntu 20.04 and installs the core20 snap.
  • Slims down the list packages installed in the image to only those explicitly needed to build the package
  • Updates snapcraft.yaml for required changes in snapcraft 4.0.x
    • Plugins are now applicable only to Snapcraft's build step.
    • go-importpath and go-packages fields have been removed
    • Now supports a license field

Resolves: #809

@andrewsomething
Copy link
Member Author

@andrewsomething andrewsomething commented Jun 9, 2020

You should be able to test this with: make snap_image; make build_local_snap

Copy link
Contributor

@hilary hilary left a comment

Looks great!

A bit of cleanup, then it is good to go.

  • In snap/snapcraft.yaml, we no longer need gcc as a build package, as we're no longer building go. 😄
  • Please delete the old snap/local/snapcraft-core18.yaml file. It was only there to preserve the work done to date on core18.

@andrewsomething andrewsomething requested a review from hilary Jun 9, 2020
@andrewsomething
Copy link
Member Author

@andrewsomething andrewsomething commented Jun 9, 2020

@hilary Updated!

hilary
hilary approved these changes Jun 9, 2020
Copy link
Contributor

@hilary hilary left a comment

:shipit:

@hilary hilary merged commit 7090025 into digitalocean:master Jun 9, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants