Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install kubernetes one click apps on cluster creation #829

Merged
merged 4 commits into from Jun 24, 2020

Conversation

keladhruv
Copy link
Member

@keladhruv keladhruv commented Jun 24, 2020

WHAT
This PR allows users to install one click applications when they create a kubernetes cluster

CHANGES

  • Added --1-click argument to kubernetes cluster create
  • Updated unit and integration test cases
  • Use Godo to install 1-click apps

SAMPLE USAGE
kubernetes cluster create testcluster --1-clicks metrics-server,linkerd2

Copy link
Member

@andrewsomething andrewsomething left a comment

Looks good! I did have one question in line. Also, it would be great to get an integration test as well. See:

https://github.com/digitalocean/doctl/blob/master/integration/kubernetes_clusters_create_test.go

commands/kubernetes.go Show resolved Hide resolved
@keladhruv
Copy link
Member Author

@keladhruv keladhruv commented Jun 24, 2020

@andrewsomething updated integration test.

@keladhruv keladhruv requested a review from andrewsomething Jun 24, 2020
Copy link
Member

@andrewsomething andrewsomething left a comment

:shipit: Looks good!

@andrewsomething andrewsomething merged commit 29a5807 into digitalocean:master Jun 24, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants