Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help for 'doctl compute droplet-action resize' #832

Merged

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Jun 30, 2020

Customer feedback on the product docs page pointed out that the current help is inadequate. This improves on it. It also marks ArgSizeSlug as required.

@andrewsomething andrewsomething requested a review from dbrian57 Jun 30, 2020
bentranter
bentranter previously approved these changes Jul 7, 2020
Copy link
Member

@bentranter bentranter left a comment

LGTM!

@andrewsomething andrewsomething requested a review from bentranter Jul 8, 2020
@andrewsomething
Copy link
Member Author

@andrewsomething andrewsomething commented Jul 8, 2020

Pushed a whitespace change and reverted it hoping to get Guardrails to actually run...

Copy link
Member

@bentranter bentranter left a comment

LGTM

@andrewsomething andrewsomething merged commit c64b208 into digitalocean:master Jul 8, 2020
2 checks passed
@andrewsomething andrewsomething deleted the asb/resize-help branch Jul 8, 2020
Copy link
Contributor

@dbrian57 dbrian57 left a comment

Other than the one comment left inline, it lgtm 👍

To also increase the Droplet's disk size, pass the ` + "`--resize-disk`" + ` flag. This is a permanent change and cannot be reversed as a Droplet's disk size cannot be decreased.
In order to resize a Droplet, it must first be powered off.`
Copy link
Contributor

@dbrian57 dbrian57 Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the indentation matter here?

@dbrian57
Copy link
Contributor

@dbrian57 dbrian57 commented Jul 10, 2020

sorry, just noticed this was merged 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants