Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godo, present confirmation prompt on app deletion #850

Merged
merged 4 commits into from Sep 9, 2020

Conversation

kamaln7
Copy link
Member

@kamaln7 kamaln7 commented Sep 8, 2020

This updates godo from v1.42.0 to v1.43.0:

I also added a confirmation prompt before deleting an app.

@andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Sep 9, 2020

It would be great to get an integration test for the delete command:

https://github.com/digitalocean/doctl/blob/master/integration/apps_test.go

@kamaln7
Copy link
Member Author

@kamaln7 kamaln7 commented Sep 9, 2020

Done!

Copy link
Member

@andrewsomething andrewsomething left a comment

Thanks for the integration test!

@andrewsomething andrewsomething merged commit 8fdb15b into digitalocean:master Sep 9, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants