Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: add defaults for deployment id and component name #851

Merged
merged 5 commits into from Sep 16, 2020

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Sep 9, 2020

This defaults the deployment ID to the current deployment, and the component name to '' so aggregate logs are used.

APPS-1547

commands/apps.go Outdated Show resolved Hide resolved
@kamaln7
Copy link
Member

@kamaln7 kamaln7 commented Sep 9, 2020

I think we should default to aggregate logs if a component name isn’t set

Edit: digitalocean/godo#364

snormore
snormore previously approved these changes Sep 9, 2020
@bouk
Copy link
Contributor Author

@bouk bouk commented Sep 14, 2020

I've updated it to use godo 1.44

Copy link
Member

@andrewsomething andrewsomething left a comment

👍 LGTM!

@andrewsomething andrewsomething merged commit 2e84776 into digitalocean:master Sep 16, 2020
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants