Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused script: script/build.sh #858

Merged
merged 1 commit into from Sep 23, 2020
Merged

Remove unused script: script/build.sh #858

merged 1 commit into from Sep 23, 2020

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Sep 23, 2020

Only scripts/_build.sh is used, not script/build.sh

$ grep --exclude-dir=vendor/ --exclude-dir=.git/ -r "build.sh" .
./Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh
./parts/doctl/build/Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh
./parts/doctl/src/Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh

The last PR touching it says:

we should deprecate this at some point and remove it, but it's not doing any harm at this point.

#554

At this point it is just more confusing to have multiple build scripts laying around.

Only `scripts/_build.sh` is used, not `script/build.sh`

```
$ grep --exclude-dir=vendor/ --exclude-dir=.git/ -r "build.sh" .
./Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh
./parts/doctl/build/Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh
./parts/doctl/src/Makefile:	@OUT_D=${OUT_D} GOOS=${GOOS} GOARCH=${GOARCH} scripts/_build.sh
```

The last PR touching it says:

> we should deprecate this at some point and remove it, but it's not doing any harm at this point.

#554

At this point it is just more confusing to have multiple build scripts laying around.
Copy link
Member

@bentranter bentranter left a comment

Looks great, thanks for getting rid of this!

@bentranter
Copy link
Member

@bentranter bentranter commented Sep 23, 2020

Also I know WhiteSource is failing, but I think Veronica is working on upgrading it as part of the Go 1.15 upgrade.

@andrewsomething andrewsomething merged commit 43a2b14 into master Sep 23, 2020
3 of 4 checks passed
@andrewsomething andrewsomething deleted the build-script branch Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants