Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test focus. #967

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Mar 9, 2021

Reviewing #966, I realized that the integration tests were not running. They were inadvertently set to focus on one test, preventing the others from running:

var _ = suite.Focus("database/firewalls", func(t *testing.T, when spec.G, it spec.S) {

This PR fixes that and updates tests that should have seen changes.

Copy link
Member

@bentranter bentranter left a comment

LGTM, thanks for catching this!

@andrewsomething andrewsomething merged commit c8b34d0 into digitalocean:main Mar 9, 2021
5 checks passed
@andrewsomething andrewsomething deleted the asb/fix-integration-test-focus branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants