Weird behaviour (remove all+add all) when changing resources in digitalocean_project

[morsik]

Hi there,

Not sure if this is related to provider itself or DigitalOcean web page, but here what's the problem.

While adding or removing resources to digitalocean_project, webpage GUI tells that everything was removed and everything was added again even I removed only 1 item from resources. This feels very wrong and I always feel I just destroyed too much.

Terraform Version

Terraform v0.14.6
+ provider registry.terraform.io/digitalocean/digitalocean v2.5.1

Affected Resource(s)

• digitalocean_project
• digitalocean_project_resources (possibly, not tested)

Expected Behavior

Web page should just show notification about removing exactly 1 item. Not removing everything and adding back again.

Actual Behavior

Shows information about removing everything!

Steps to Reproduce

Terraform Configuration Files

Just create simpliest digitalocean_project like:

# of course here you need those actual resources too, I'm not entering them for simplicity

resource "digitalocean_project" "labs" {
  name        = "labs"
  resources = [
    digitalocean_domain.lab.urn,
    digitalocean_droplet.swarmtest_01.urn,
    digitalocean_droplet.swarmtest_02.urn,
    digitalocean_droplet.swarmtest_03.urn,
  ]
}

Apply Terraform. Check webpage (you'll see 3 Droplets in this Project).

After checking, remove one Droplet resource (for ex digitalocean_droplet.swarmtest_03.urn). Apply and check again. If you slow enough, everything will look fine, but if you were watching DigitalOcean webpage in real-time you'll see that all resources were actually deleted from this project (and moved to main project) and then restored back again (without the one you removed).

Also there is a lot of notifications about this:

[andrewsomething]

Thanks for raising this issue. It looks it currently does remove all resource and then adds them back:

terraform-provider-digitalocean/digitalocean/resource_digitalocean_project.go

Lines 208 to 209 in 2c4bf56

	// The API requires project resources to be reassigned to another project if the association needs to be deleted.
	// a diff of the resource could be implemented instead of removing all, (bulk) and adding the back again.

We can definitely improve the experience here.