Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private_networking = false, seems to be ignored #676

Closed
cameronelliott opened this issue Aug 25, 2021 · 1 comment · Fixed by #677
Closed

private_networking = false, seems to be ignored #676

cameronelliott opened this issue Aug 25, 2021 · 1 comment · Fixed by #677
Labels

Comments

@cameronelliott
Copy link

@cameronelliott cameronelliott commented Aug 25, 2021

Describe the bug

Creating an instance with private_networking = false appears to have the private networking enabled anyway,
both in reality and in the terraform show output.
I'm sorta new to Terraform, so if this is somehow a user mistake (or my mistake), my apologies.

Affected Resource(s)

  • digitalocean_droplet

Expected Behavior

I would think the output of terraform show|grep priv would show that private networking would be false, not true, given the apply preview and the .tf file show private_networking = false.

Actual Behavior

terraform show indicates that private networking was enabled.

[email protected] ~/D/t/d/bug> terraform show|grep priv
    ipv4_address_private = "10.132.0.3"
    private_networking   = true
[email protected] ~/D/t/d/bug>

Steps to Reproduce

terraform init
terraform apply -var "do_token=$DIGITALOCEAN_ACCESS_TOKEN" -var "pvt_key=$HOME/.ssh/id_rsa" -auto-approve

Full log at gist link, with .tf files.

Terraform Configuration Files
https://gist.github.com/cameronelliott/9ef23e442572891937b0ed1c0c843f3f

Terraform version

[email protected] ~/D/t/d/bug> terraform -v
Terraform v1.0.5
on darwin_amd64
+ provider registry.terraform.io/digitalocean/digitalocean v2.11.1
[email protected] ~/D/t/d/bug>

Captured log Output
https://gist.github.com/cameronelliott/9ef23e442572891937b0ed1c0c843f3f

@danaelhe
Copy link
Contributor

@danaelhe danaelhe commented Aug 26, 2021

Hi there,

Thanks for reaching out. The private_networking has been marked deprecated and vpc_uuid should be used instead to specify a VPC network for the Droplet. This has been stated here, but I can see how that documentation is not obvious to check for, so I will update the API docs and mark the attribute as deprecated in the schema definition. Thanks for bringing this to our attention.

danaelhe added a commit that referenced this issue Aug 26, 2021
editing documentation to include private_networking has been deprecated.
danaelhe added a commit that referenced this issue Aug 26, 2021
editing documentation to include private_networking has been deprecated.
@andrewsomething andrewsomething linked a pull request Aug 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants