Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add digitalocean_records data source #502

Merged
merged 5 commits into from Oct 20, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Oct 17, 2020

Adds a digitalocean_records data source to access DNS records of a domain.

Note: This PR modifies the datalist package to support "extra queries." I've exposed that by having an alternate set of callbacks that take a *schema.ResourceData. It might be better to just port the existing datalist uses to take that argument and avoid having two sets of functions. Thoughts?

@andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Oct 19, 2020

It might be better to just port the existing datalist uses to take that argument and avoid having two sets of functions.

👍 Sounds like a good approach.

@tdyas
Copy link
Contributor Author

@tdyas tdyas commented Oct 20, 2020

The latest commit switches the PR to just putting the extra query map onto the existing GetRecords and FlattenRecord functions.

Copy link
Member

@andrewsomething andrewsomething left a comment

👍 Looks great!

@andrewsomething andrewsomething merged commit 4ace704 into digitalocean:master Oct 20, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants