Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on pull_request not pull_request_target. #589

Merged
merged 2 commits into from Feb 19, 2021
Merged

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Feb 19, 2021

Run tests on pull_request not pull_request_target to prevent failures like this from only being found after merge into main.

https://github.com/digitalocean/terraform-provider-digitalocean/runs/1936909608?check_suite_focus=true

@andrewsomething
Copy link
Member Author

@andrewsomething andrewsomething commented Feb 19, 2021

Note that pull_request_target is expected to fail as it does not have the changes from this branch.

Copy link
Member

@ChiefMateStarbuck ChiefMateStarbuck left a comment

LGTM

@ChiefMateStarbuck ChiefMateStarbuck merged commit c38663c into main Feb 19, 2021
2 of 4 checks passed
@andrewsomething andrewsomething deleted the asb/workflow branch Feb 19, 2021
andrewsomething added a commit that referenced this issue Apr 26, 2021
* Run tests on pull_request not pull_request_target.

* Run gofmt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants