Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Support setting CORS policies. #699

Merged
merged 6 commits into from Sep 20, 2021
Merged

apps: Support setting CORS policies. #699

merged 6 commits into from Sep 20, 2021

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Sep 17, 2021

Opening this as a draft for now as it still needs docs and more tests.

Related to: #686

@atombrella
Copy link
Contributor

@atombrella atombrella commented Sep 20, 2021

I had started a bit with this, but couldn't get the tests (flatten and expand problems) working. However, maybe copy-pasting the docs? [email protected]f8dd074#diff-2a77bc4b1d9ab16d12a37ea007beade1793d351c331bbb132899ffd61aa17efa

@andrewsomething andrewsomething marked this pull request as ready for review Sep 20, 2021
scotchneat
scotchneat previously approved these changes Sep 20, 2021
Copy link
Member

@scotchneat scotchneat left a comment

Looks great. I just have one question about the tests but it's not a blocker.

@andrewsomething andrewsomething requested a review from scotchneat Sep 20, 2021
Copy link
Member

@scotchneat scotchneat left a comment

LGTM

@scotchneat scotchneat merged commit 65a06fe into main Sep 20, 2021
3 checks passed
@andrewsomething andrewsomething deleted the asb/apps/cors branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants