Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test workflow #732

Merged
merged 3 commits into from Oct 27, 2021

Conversation

scotchneat
Copy link
Member

@scotchneat scotchneat commented Oct 27, 2021

This updates the test.yml workflow to include a job to run the acceptance tests.

The acceptance job uses a deployment environment in the github repo which has been configured with the appropriate secrets. It's also configured to require reviews by the @digitalocean/api-cli team before the job will run. Finally, the job has continue-on-error: true. The idea is to allow this job to be added as a check to PRs but isn't required to succeed for the PR to be merged.

The make testacc step sets the env var TESTARGS=-parallel 20 but the entire suite still takes over 30 minutes to complete.

Copy link
Member

@andrewsomething andrewsomething left a comment

👍 LGTM!

As you changed the name of the test job, I think you'll need to go into settings and update the branch protection rules to be able to merge this.

@scotchneat
Copy link
Member Author

@scotchneat scotchneat commented Oct 27, 2021

👍🏽 Done
Edit: Well, I added the unit jobs but didn't remove the test ones yet so they're still required. I figured I'd leave them if there were any concerns while this got reviewed.

@andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Oct 27, 2021

This shouldn't block this, but we should consider running make sweep in a subsequent step.

@scotchneat scotchneat merged commit 37bde6f into digitalocean:main Oct 27, 2021
4 checks passed
@scotchneat scotchneat deleted the acceptance-test-workflow branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants