Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker creds: Revoke token on delete. #735

Merged
merged 3 commits into from Nov 1, 2021
Merged

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Oct 29, 2021

As the concept being used here is "destroying" the credentials, we should really revoke the generated token.

Fixes: #726

@andrewsomething andrewsomething requested a review from Oct 29, 2021
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests Oct 29, 2021 Inactive
Copy link
Member

@bentranter bentranter left a comment

LGTM!

@andrewsomething andrewsomething temporarily deployed to Acceptance Tests Nov 1, 2021 Inactive
@andrewsomething andrewsomething merged commit cca1804 into main Nov 1, 2021
4 checks passed
@andrewsomething andrewsomething deleted the asb/revoke-docker-creds branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants