Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add option to preview the contents of the current cycle_view #217

Merged
merged 1 commit into from Jan 23, 2022

Conversation

liam-middlebrook
Copy link
Contributor

@liam-middlebrook liam-middlebrook commented Jan 21, 2022

Add the 'cycleViewPreview.core' option to rc.xml to enable previews of
the selected view when cycling between windows. Default this option to
be disabled to match current behavior.

@johanmalm
Copy link
Collaborator

@johanmalm johanmalm commented Jan 21, 2022

I like the look of this. @ARDiDo @Consolatis et al. We should probably do this by default. What do you think?

@Consolatis
Copy link
Contributor

@Consolatis Consolatis commented Jan 21, 2022

I don't know yet if I personally like it. I'd have to use it for some time to make up my mind, especially in combination with the high contrast double borders. But as it can be turned off I am totally fine with the feature as such. About turning it on by default: I have no strong opinion in either direction.

PR misses rendering server side decoration though, so there is a transparent hole between the top border and the client window which looks pretty weird.

@liam-middlebrook
Copy link
Contributor Author

@liam-middlebrook liam-middlebrook commented Jan 21, 2022

PR misses rendering server side decoration though, so there is a transparent hole between the top border and the client window which looks pretty weird.

Huh, I've been using it for a few days and somehow missed that. Thanks for pointing that out. I'll fix that up and update the PR shortly.

Add the 'cycleViewPreview.core' option to rc.xml to enable previews of
the selected view when cycling between windows. Default this option to
be disabled to match current behavior.
@Joshua-Ashton
Copy link
Contributor

@Joshua-Ashton Joshua-Ashton commented Jan 22, 2022

I tend to have a lot, ~30 windows open at once. An option to show only that window would be appreciated also.

@ARDiDo
Copy link
Contributor

@ARDiDo ARDiDo commented Jan 22, 2022

I like it. I think it makes cycling views belonging to the same program much easier. This should probably be enabled by default.

@johanmalm johanmalm merged commit 875b258 into labwc:master Jan 23, 2022
1 check passed
@johanmalm
Copy link
Collaborator

@johanmalm johanmalm commented Jan 23, 2022

Right - I've done it 😄
Guess we just need to agree what the default should be before the 0.5.0 tag.

@johanmalm
Copy link
Collaborator

@johanmalm johanmalm commented Jan 23, 2022

Having played with it, I think this is definitely much better. I vote for enabled by default.

@Joshua-Ashton I don't follow your thought. Do you mean to hide all other views and only render server->cycle_view during alt-tab?

@Consolatis
Copy link
Contributor

@Consolatis Consolatis commented Jan 23, 2022

@johanmalm

Guess we just need to agree what the default should be before the 0.5.0 tag.

I strongly suggest either reverting or fixing 6651d45 before tagging a new release. Context 1, Context 2.

Maybe you could open an issue whenever you plan on tagging a release.
That issue could then contain a list of release-blocking issues that should be fixed before doing the actual release.

@johanmalm
Copy link
Collaborator

@johanmalm johanmalm commented Jan 24, 2022

@johanmalm

Guess we just need to agree what the default should be before the 0.5.0 tag.

I strongly suggest either reverting or fixing 6651d45 before tagging a new release. Context 1, Context 2.

Maybe you could open an issue whenever you plan on tagging a release. That issue could then contain a list of release-blocking issues that should be fixed before doing the actual release.

I've reverted 6651d45 2652522

Will open issue to help manage approach to next release. Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants