Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the WebGL terminal renderer the default #118064

Closed
Tyriar opened this issue Mar 3, 2021 · 1 comment · Fixed by #118011 or #119883
Closed

Make the WebGL terminal renderer the default #118064

Tyriar opened this issue Mar 3, 2021 · 1 comment · Fixed by #118011 or #119883
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-rendering verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2021

Part of #106202

We should also improve the fallback logic to do this:

  • Try webgl
  • If it threw an exception, try canvas
  • If frame rendering averages > 50ms (existing detection), use DOM

We will keep the canvas renderer around for now mainly because Safari doesn't support webgl2 and can evaluate whether we want to remove it again at a later date.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues terminal-rendering labels Mar 3, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 3, 2021
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Mar 23, 2021
@rzhao271 rzhao271 added verified Verification succeeded verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Mar 24, 2021
@connor4312 connor4312 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Mar 24, 2021
@connor4312
Copy link
Member

connor4312 commented Mar 24, 2021

It looks like canvas is still the default for me -- the xterm-text-layer is present unless I explicitly enable experimentalWebgl. I don't see any notifications of errors that could be causing it.

@connor4312 connor4312 added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Mar 24, 2021
Tyriar added a commit that referenced this issue Mar 25, 2021
@Tyriar Tyriar reopened this Mar 25, 2021
Tyriar added a commit that referenced this issue Mar 25, 2021
@Tyriar Tyriar self-assigned this Mar 25, 2021
@connor4312 connor4312 added the verified Verification succeeded label Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-rendering verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
5 participants