Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make webgl default renderer #118011

Merged
merged 10 commits into from Mar 4, 2021
Merged

make webgl default renderer #118011

merged 10 commits into from Mar 4, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 3, 2021

and catch if loading the addon fails, going w dom in that case

This PR is a part of #106202
Fixes #118064

@meganrogge meganrogge added this to the March 2021 milestone Mar 3, 2021
@meganrogge meganrogge requested a review from Tyriar Mar 3, 2021
@meganrogge meganrogge self-assigned this Mar 3, 2021
Copy link
Member

@Tyriar Tyriar left a comment

I was thinking about the frame measurement and maybe we don't need to do that with webgl as I don't think browsers are able to fallback to CPU for that like they do with a 2d canvas context. So we shouldn't see the massive change in render time, it just works or doesn't and throws.

@meganrogge meganrogge requested a review from Tyriar Mar 3, 2021
@meganrogge meganrogge enabled auto-merge (rebase) Mar 4, 2021
@meganrogge meganrogge merged commit 8a81f41 into main Mar 4, 2021
13 checks passed
@meganrogge meganrogge deleted the merogge/renderer branch Mar 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants