Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose loader/action headers on error responses in static handler #9140

Merged
merged 1 commit into from Sep 8, 2022

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Aug 9, 2022

For static handler query() calls, we propagate out the headers from any returned Response instances for eventual use in the SSR response (getDocumentHeaders in Remix). This PR ensures we also capture those on error flows (i.e., throw new Response)

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

⚠️ No Changeset found

Latest commit: 0e0b687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 changed the title fix: expose leader/action headers on error response sin static handler fix: expose leader/action headers on error responses in static handler Aug 9, 2022
@brophdawg11 brophdawg11 changed the title fix: expose leader/action headers on error responses in static handler fix: expose loader/action headers on error responses in static handler Aug 9, 2022
@brophdawg11 brophdawg11 merged commit 5cfde28 into dev Sep 8, 2022
2 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/static-handler-error-headers branch Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant